[docs] Lazy load landing page images #17827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
added
new feature
Details of bundle changes.Comparing: 6b9ecbe...1dabd42
|
| @@ -205,6 +205,9 @@ function HomeSteps(props) { | |||
| className={classes.img} | |||
| alt="themes" | |||
| src={`/static/images/themes-${theme.palette.type}.jpg`} | |||
| loading="eager" | |||
| width={500} | |||
There was a problem hiding this comment.
I believe we override the dimension with CSS, do we need to specify something here?
There was a problem hiding this comment.
The browser needs to to calculate a proper placeholder and avoid layout shifts.
|
Resolved conflicts with #17830. |
eps1lon
force-pushed
the
docs/image-lazy
branch
from
e70a633
to
1dabd42
Compare
oliviertassinari
approved these changes
Oct 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
preview
Uses
loading="lazy"for every image on the landing page except the themes which are eagerly loaded (since they are a conversion target).This does not have any effect on desktop viewports. At around 300-400 px height you get some images lazy loaded but only the logos of the companies that use our components. I guess this is fine for now since the benefit will only go up with more content on the landing page.
It might make sense to use this on other pages as well. Though I would not use it in any demo since it's very new and only supported on recent chrome releases. I want to avoid that people use those in their actual apps assuming it's either implemented by Material-UI or by our supported browsers.